[webkit-reviews] review granted: [Bug 69750] NRWT should handle duplicated expectations : [Attachment 117663] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 2 14:58:21 PST 2011

Dirk Pranke <dpranke at chromium.org> has granted Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 69750: NRWT should handle duplicated expectations

Attachment 117663: proposed fix

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117663&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:791
> +

Minor nit ... _is_lint_mode makes warnings errors. If you want these to fail
only in lint mode, I'd just change these to _skipped_tests_warnings and append
them to the warnings list. CQ-'ing just for that.

There is actually a separate discussion about making the expectations errors
less fatal going on in https://bugs.webkit.org/show_bug.cgi?id=73603 ; fixing
that bug might've made this bug unnecessary, but I think there's good work in
this patch to clean up our handling of skipped files regardless.

More information about the webkit-reviews mailing list