[webkit-reviews] review granted: [Bug 73609] Grant workers experimental access to IndexedDB. : [Attachment 117668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 2 14:06:23 PST 2011


Nate Chapin <japhet at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 73609: Grant workers experimental access to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=73609

Attachment 117668: Patch
https://bugs.webkit.org/attachment.cgi?id=117668&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117668&action=review


Per comment #18, I'm taking on faith that this is correct from a threading
perspective.

Otherwise, this seems sane.

> Source/WebCore/storage/IDBFactory.cpp:85
> +    ASSERT(context->isDocument() || context->isWorkerContext());

Is this ASSERT actually necessary? I thought these were the only 2 types of
ScriptExecutionContexts


More information about the webkit-reviews mailing list