[webkit-reviews] review requested: [Bug 72964] [chromium] Let LayerChromium subclasses override value of opaque() flag. Set it for image, video, and canvas layers. : [Attachment 117665] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 72964: [chromium] Let LayerChromium subclasses override value of opaque()
flag. Set it for image, video, and canvas layers.
https://bugs.webkit.org/show_bug.cgi?id=72964

Attachment 117665: Patch
https://bugs.webkit.org/attachment.cgi?id=117665&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
This pushes the idea of painted contents being opaque off to the layer
delegate, and makes the LayerChromium opaque bits independent from that, where
layers set their opaque flag intelligently based on internal knowledge about
themselves.

- Removed hasAlpha from CanvasLayer and CCCanvasLayer (they can use opaque()
for this).
- Removed GLC::setContentsOpaque/updateContentsOpaque. The contentsOpaque is
going to be something to be queried off the CCLayerDelegate after
paintContents().
- Added contentsOpaque to various CCLayerDelegates in the WebLayer hierarchy.
- LC subclasses just setOpaque() directly.
- Added VideoFrameChromium::isFrameOpaque().