[webkit-reviews] review requested: [Bug 73672] [Chromium] Add Android keycodes and build Linux clipboard/filesystem files. : [Attachment 117647] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 2 10:14:00 PST 2011
Peter Beverloo <peter at chromium.org> has asked for review:
Bug 73672: [Chromium] Add Android keycodes and build Linux clipboard/filesystem
files.
https://bugs.webkit.org/show_bug.cgi?id=73672
Attachment 117647: Patch
https://bugs.webkit.org/attachment.cgi?id=117647&action=review
------- Additional Comments from Peter Beverloo <peter at chromium.org>
Note for the reviewers: An alternative solution to adding a new
IconChromiumAndroid.cpp file would be to #ifdef out the implementation in
IconChromium.cpp, but overall I think this is cleaner.
http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore
/platform/graphics/chromium/IconChromium.cpp&exact_package=chromium&q=IconChrom
ium.cpp&type=cs&l=48
More information about the webkit-reviews
mailing list