[webkit-reviews] review granted: [Bug 73641] WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed : [Attachment 117598] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 73641: WebKit2: Freeze the state of the layer tree until frame load
completion if incremental rendering is suppressed
https://bugs.webkit.org/show_bug.cgi?id=73641

Attachment 117598: Patch
https://bugs.webkit.org/attachment.cgi?id=117598&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117598&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:537
> -    if (m_frame == m_frame->page()->mainWebFrame())
> +    if (m_frame == m_frame->page()->mainWebFrame() &&
!webPage->corePage()->settings()->suppressIncrementalRendering())
>	   webPage->drawingArea()->setLayerTreeStateIsFrozen(false);

Seems OK, but perhaps a bit of a layering problem that this code needs to check
the setting.

Not sure why this code gets to the page as m_frame->page() in one half of the
expression and as webPage->corePage() in the other. Aren’t those guaranteed to
be the same page?