[webkit-reviews] review granted: [Bug 73477] Prepare to deploy pass and peek types in the HashMap class : [Attachment 117552] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 2 08:38:04 PST 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 73477: Prepare to deploy pass and peek types in the HashMap class
https://bugs.webkit.org/show_bug.cgi?id=73477

Attachment 117552: Patch
https://bugs.webkit.org/attachment.cgi?id=117552&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117552&action=review


> Source/JavaScriptCore/wtf/HashSet.h:73
> +	   // FIXME: We should reverse the order of the template arguments so
that callers
> +	   // can just pass the translator let the compiler deduce T.

I think you're missing a word in there.

> Source/JavaScriptCore/wtf/HashSet.h:88
> +	   // FIXME: We should reverse the order of the template arguments so
that callers
> +	   // can just pass the translator let the compiler deduce T.

Ditto.


More information about the webkit-reviews mailing list