[webkit-reviews] review granted: [Bug 72933] "Raw" pseudo selectors don't match if immediately after a child or descendant combinator : [Attachment 117565] patch, v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 72933: "Raw" pseudo selectors don't match if immediately after a child or
descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Attachment 117565: patch, v2
https://bugs.webkit.org/attachment.cgi?id=117565&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=117565&action=review


> Source/WebCore/css/CSSParser.cpp:7677
> +    // Note that CSSSelector::ShadowDescendant needs to be used.
> +    // Therefore we create a new Selector here in any case, even if matching
any (host) element in any namespace.

I have difficulties understanding this comment (especially if I don't see the
old removed text).

> Source/WebCore/css/CSSSelector.cpp:637
> +	       if (tagHistoryText.endsWith("*"))
> +		   tagHistoryText.truncate(tagHistoryText.length() - 1);

It would be nicer not to add the * in the first place (or just leave it) but
ok.