[webkit-reviews] review denied: [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image. : [Attachment 117571] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 70304: width/height attributes of input element should be supported when
the type of the input element is image.
https://bugs.webkit.org/show_bug.cgi?id=70304

Attachment 117571: Patch
https://bugs.webkit.org/attachment.cgi?id=117571&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117571&action=review


> LayoutTests/fast/forms/input-width-height-attributes.html:54
> +var div1 = document.getElementById("div1");

The variable div1 - div8 are not needed.

> LayoutTests/fast/forms/input-width-height-attributes.html:86
> +text1.width = 100;
> +text1.height = 50;
> +debug('Test case #5 : Text, Setting by JavaScript API as \"100\", \"50\"');
> +shouldBe('text1.width,text1.height', '0,0');
> +

After this, we had better test:
 - text1 has width= and height= HTML attributes.
 - Changing the type to image, width/height values are not changed.

> Source/WebCore/html/InputType.cpp:753
> +void InputType::setHeight(unsigned height)
> +{
> +    element()->setAttribute(heightAttr, String::number(height));
> +}
> +
> +void InputType::setWidth(unsigned width)
> +{
> +    element()->setAttribute(widthAttr, String::number(width));
> +}
> +

No other *InputType overrides setHeight() and setWidth().  We can remove them
and move the code to HTMLInputElement::setHeight()/setWidth().