[webkit-reviews] review requested: [Bug 72715] Implement AccessKeyLabel attribute. : [Attachment 117549] updated_patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 20:07:19 PST 2011

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 72715: Implement AccessKeyLabel attribute.

Attachment 117549: updated_patch

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #23)
> (From update of attachment 117356 [details])
> View in context:
> > LayoutTests/fast/forms/access-key-label.html:20
> > +if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
> > +	 shouldBe("input_item.accessKeyLabel",'Ctrl+Alt+A');
> > +else
> > +	 shouldBe("input_item.accessKeyLabel","'Alt+A'");
> This still looks wrong to me. These are not the expected values on Mac, so
it's not something to fix in test expectations.

Ahh right, Sorry I forgot modify the test case after new code for Mac.
Currently I have access to gtk port so I have added the test in
test_expectations because for Mac test behavior would be the different from gtk
which I think needs to be rebaseline.

More information about the webkit-reviews mailing list