[webkit-reviews] review granted: [Bug 73584] Changes proposed for 73457 slow down Kraken json-parse-financial : [Attachment 117475] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 19:44:16 PST 2011


Sam Weinig <sam at webkit.org> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 73584: Changes proposed for 73457 slow down Kraken json-parse-financial
https://bugs.webkit.org/show_bug.cgi?id=73584

Attachment 117475: Patch
https://bugs.webkit.org/attachment.cgi?id=117475&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117475&action=review


Please take Darin's comment into account.

> Source/JavaScriptCore/wtf/text/StringImpl.cpp:754
> +    if (length & 1 &&  *reinterpret_cast<const UChar*>(aCharacters) !=
*reinterpret_cast<const UChar*>(bCharacters))

Extra whitespace between &&  *


More information about the webkit-reviews mailing list