[webkit-reviews] review denied: [Bug 70645] [chromium] Recycle tile-sized textures during commit to prevent reallocations : [Attachment 117533] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Grace Kloba
<klobag at chromium.org>'s request for review:
Bug 70645: [chromium] Recycle tile-sized textures during commit to prevent
reallocations
https://bugs.webkit.org/show_bug.cgi?id=70645

Attachment 117533: Patch
https://bugs.webkit.org/attachment.cgi?id=117533&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117533&action=review


> Source/WebCore/platform/graphics/chromium/ManagedTexture.h:74
> +    bool m_contentsValid;

I believe you can remove this

> Source/WebCore/platform/graphics/chromium/TextureManager.cpp:272
> +	   if (textureId > 0)

textureId is of type unsigned so it can never be < 0 and WebKit style prefers
that checks for == 0 be written this way:

if (textureId)

> Source/WebCore/platform/graphics/chromium/TextureManager.h:52
> +    static PassOwnPtr<TextureManager> create(size_t memoryLimitBytes, size_t
reclaimLimitBytes, int maxTextureSize)

this change should not be part of this patch - it's not about texture
recycling. please remove it

> Source/WebCore/platform/graphics/chromium/TextureManager.h:67
> +    void setReclaimLimitBytes(size_t);

same here - this patch should only have changes related to texture recycling.
we can do this later if/when it becomes useful