[webkit-reviews] review granted: [Bug 73420] Add a way to automatically size a single frame to fit its content. : [Attachment 117517] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 73420: Add a way to automatically size a single frame to fit its content.
https://bugs.webkit.org/show_bug.cgi?id=73420

Attachment 117517: Patch
https://bugs.webkit.org/attachment.cgi?id=117517&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117517&action=review


> Source/WebCore/ChangeLog:8
> +	   No new functionality exposed so no new tests. (There is a Chromium

It might be a separate patch, but it seems having it exposed at least via
Chromium API and in Chromium DRT is what we want to do in order to add more
tests. This will need more tests.

> Source/WebCore/page/FrameView.cpp:2331
> +	   // Increase the dimensions due to any scrollbars that are displayed.


The comment should be updated to reflect the fact that these address situation
when only one of the dimensions is over the limit - because if both are inside
the limit there is no scrolbars and if both are outside the limit - then the
limit already took care of both.