[webkit-reviews] review denied: [Bug 73594] [chromium] Add plumbing for supporting custom MIME types in DataTransfer. : [Attachment 117500] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 73594: [chromium] Add plumbing for supporting custom MIME types in
DataTransfer.
https://bugs.webkit.org/show_bug.cgi?id=73594

Attachment 117500: Patch
https://bugs.webkit.org/attachment.cgi?id=117500&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117500&action=review


> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:187
> +
>      return String();

I think we still need to set success = false; here.

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:237
> +    m_customData.set(type, data);
> +    return true;

I see, so setData will always succeed now.

> LayoutTests/platform/chromium/test_expectations.txt:3738
> +// Depends on Chromium follow up change before they will pass.
> +BUG_DCHENG : fast/events/drag-customData.html = FAIL

Maybe just reference BUGCR31037 here?