[webkit-reviews] review denied: [Bug 73591] [Qt] [WK2] Webkit should TextureMapper GL objects if page paint node is deallocated. : [Attachment 117497] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 73591: [Qt] [WK2] Webkit should TextureMapper GL objects if page paint node
is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591

Attachment 117497: patch
https://bugs.webkit.org/attachment.cgi?id=117497&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117497&action=review


See comments.
Question, what are we doing with directly-composited images? Would that come in
a different patch?

> Source/WebCore/ChangeLog:3
> +	   [Qt] [WK2] Webkit should TextureMapper GL objects if page paint node
is deallocated.

I think this is missing a verb (release?).

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:579
> +void WebGraphicsLayer::reCreateTiledBackingStore()

Let's call it recreateTiledBackingStoreIfNeeded

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:591
> +}

Don't you need to regenerate the content as well, e.g. setNeedsDisplay ?

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:87
> +    virtual void needTileBuffersRecreate() { }

purgeTiledBackingStores (?)

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:69
> +    , m_needTileBuffersRecreate(false)

m_shouldRecreateTileBuffers