[webkit-reviews] review denied: [Bug 73585] Add a helper method to find whether an html page has custom page size styles. : [Attachment 117472] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied kmadhusu <kmadhusu at chromium.org>'s
request for review:
Bug 73585: Add a helper method to find whether an html page has custom page
size styles.
https://bugs.webkit.org/show_bug.cgi?id=73585

Attachment 117472: Patch
https://bugs.webkit.org/attachment.cgi?id=117472&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review


> Source/WebCore/dom/Document.cpp:1698
> +    RefPtr<RenderStyle> style = styleForPage(pageIndex);
> +    return style->pageSizeType() != PAGE_SIZE_AUTO;

This function should not be added. You can just put all the code at at the call
site in WebFrameImpl.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1481
> +    return frame()->document()->hasCustomPageSizeStyle(pageIndex);

return frame->document()->styleForPage(pageIndex)->pageSizeType() !=
PAGE_SIZE_AUTO;