[webkit-reviews] review granted: [Bug 73592] REGRESSION (r100483):=?UTF-8?Q?=20Can=E2=80=99t=20drag=20out=20of=20background=20window=20?=: [Attachment 117496] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 73592: REGRESSION (r100483): Can’t drag out of background window
https://bugs.webkit.org/show_bug.cgi?id=73592

Attachment 117496: Patch 
https://bugs.webkit.org/attachment.cgi?id=117496&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117496&action=review


Is there a good way to regression-test this?

> Source/WebKit2/ChangeLog:4
> +	   REGRESSION (r100483): Can’t drag out of background window

Character encoding trouble here with the ’ character.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1188
> +	   // We need to do a full, normal hit test during this mouse event if
the page is active or if a mouse
> +	   // button is currently pressed. It is possible that neither of those
things will be true since on 
> +	   // Lion when legacy scrollbars are enabled, WebKit receives mouse
events all the time. If it is one 
> +	   // of those cases where the page is not active and the mouse is not
pressed, then we can fire a more
> +	   // efficient scrollbars-only version of the event.
> +	   bool mouseIsPressed = mouseEvent.button() !=
WebMouseEvent::NoButton;
> +	   handled = handleMouseEvent(mouseEvent, m_page.get(),
!(m_page->focusController()->isActive() || mouseIsPressed));

To make the code match the comment it would be better if the third argument was
a named local variable called something like
"useMoreEfficientScrollbarsOnlyVersion".