[webkit-reviews] review granted: [Bug 73540] [EFL] Cleanup includes to reduce code complexity. : [Attachment 117368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 14:44:57 PST 2011

Gustavo Noronha (kov) <gns at gnome.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 73540: [EFL] Cleanup includes to reduce code complexity.

Attachment 117368: Patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117368&action=review

>> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:-41
>> -#endif
> I've always wondered what the correct place to put #includes inside #if
clauses was. The style guide does not have an item for this, so can you clarify
why these should be moved down?

I don't remember where I read this, but I do remember reading somewhere that
having the headers included conditionally should be at the bottom, indeed.

> Source/WebKit/efl/ewk/ewk_frame.cpp:55
>  #include "ewk_private.h"
>  #include <Eina.h>

This empty line should not exist.

> Source/WebKit/efl/ewk/ewk_private.h:39
> +#include "ewk_view.h"
> -#include <cairo.h>
> +#include <Evas.h>

Same here.

> Source/WebKit/efl/ewk/ewk_window_features.cpp:28
>  #include "WindowFeatures.h"
> +#include "ewk_logging.h"
>  #include "ewk_private.h"
>  #include <Eina.h>


More information about the webkit-reviews mailing list