[webkit-reviews] review denied: [Bug 73349] compareBorders() is called too often during painting : [Attachment 117474] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 14:39:47 PST 2011

Darin Adler <darin at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 73349: compareBorders() is called too often during painting

Attachment 117474: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117474&action=review

> Source/WebCore/rendering/RenderTable.h:203
> +    bool invalidCollapsedBorders()

The name of a boolean member function should finish the sentence “table <xxx>”
so the name would be something like “has invalid collapsed borders” or “needs
to recompute collapsed borders”.

    bool hasInvalidCollapsedBorders() const


    bool needsToRecomputeCollapsedBorders() const

> Source/WebCore/rendering/RenderTableSection.cpp:1316
> +    m_cellCollapsedBorders.set(cell, newCellInfo);

There’s a storage leak here if the map already has a stale CellCollapsedBorders
for this cell.

More information about the webkit-reviews mailing list