[webkit-reviews] review requested: [Bug 73379] [chromium] add setOpener method to WebFrame : [Attachment 117478] Patch update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 13:43:08 PST 2011

Karl Koscher <supersat at chromium.org> has asked	for review:
Bug 73379: [chromium] add setOpener method to WebFrame

Attachment 117478: Patch update

------- Additional Comments from Karl Koscher <supersat at chromium.org>
(In reply to comment #2)
> (From update of attachment 117080 [details])
> View in context:
> > Source/WebKit/chromium/public/WebFrame.h:221
> > +	 virtual void setOpener(const WebFrame*) = 0;
> nit: please preserve two new lines above section header

> note: we already have opener() and clearOpener().  it seems like setOpener()
should be
> listed next to those.  also, perhaps we should delete clearOpener() in favor
of setOpener(0).
> you could at least implement clearOpener() as an inline call to setOpener(0).

I have no idea why I put setOpener there. I moved it and made clearOpener an
inline call to setOpener(0).

> > Source/WebKit/chromium/src/WebFrameImpl.cpp:768
> > +	     static_cast<const WebFrameImpl *>(frame)->m_frame : 0);
> nit: no space after "WebFrameImpl"

Oops. Old habits. :) Fixed.

More information about the webkit-reviews mailing list