[webkit-reviews] review denied: [Bug 73530] Optimize to not use pow() in the inner loop in AudioParamTimeline : [Attachment 117360] optimize to not use pow in the inner loop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 11:39:03 PST 2011


Kenneth Russell <kbr at google.com> has denied Wei James <james.wei at intel.com>'s
request for review:
Bug 73530: Optimize to not use pow() in the inner loop in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=73530

Attachment 117360: optimize to not use pow in the inner loop
https://bugs.webkit.org/attachment.cgi?id=117360&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Raymond and I both reviewed the math and it looks correct. Despite the fact
that the ramp function might be redefined soon, I think it's worth adding this
optimization.

I think the patch needs to be rebaselined to top of tree though. Could you take
care of that? r- just for this issue.


More information about the webkit-reviews mailing list