[webkit-reviews] review granted: [Bug 73345] [chromium] Split scrollRootLayer() into scroll{Begin, By, End}() : [Attachment 117421] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 73345: [chromium] Split scrollRootLayer() into scroll{Begin,By,End}()
https://bugs.webkit.org/show_bug.cgi?id=73345

Attachment 117421: Patch
https://bugs.webkit.org/attachment.cgi?id=117421&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117421&action=review


This looks great. R=me but I can't set cq+ since this patch has merge
conflicts.

> Source/WebCore/platform/graphics/chromium/cc/CCInputHandler.h:63
> +    // Stop scrolling the layer selected with scrollBegin().

It appears from the logic that you only need to call this when scrollBegin()
returns ScrollStarted, which makes sense to me. Could you document this
requirement in the header?