[webkit-reviews] review granted: [Bug 73575] webkitpy doesn't provide a way to parse htdigest files : [Attachment 117444] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 73575: webkitpy doesn't provide a way to parse htdigest files
https://bugs.webkit.org/show_bug.cgi?id=73575

Attachment 117444: Patch
https://bugs.webkit.org/attachment.cgi?id=117444&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117444&action=review


You are an amazing man, Dr. Roben.  Amazing man.

> Tools/Scripts/webkitpy/common/net/htdigestparser.py:41
> +    @staticmethod
> +    def parse_file(digest_file):

I'm not sure I would have bothered to make it static, but in this case I don't
think it matters.  (I'm very anti-static methods these days, as I've been
bitten by their non-mockability in the last year trying to test all of
webkitpy.)