[webkit-reviews] review granted: [Bug 73458] [GTK] Add compilation options to enable/disable Accelerated Compositing and to choose texture mapper implementation. : [Attachment 117431] Option to choose AC method to use

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 73458: [GTK] Add compilation options to enable/disable Accelerated
Compositing and to choose texture mapper implementation.
https://bugs.webkit.org/show_bug.cgi?id=73458

Attachment 117431: Option to choose AC method to use
https://bugs.webkit.org/attachment.cgi?id=117431&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117431&action=review


Just a couple minor changes to suggest. I will land this with my suggestions.

> Source/WebCore/GNUmakefile.am:568
> +if USE_ACCELERATED_COMPOSITING_TEXTURE_MAPPER_CAIRO

I think we should call these TEXTURE_MAPPER AND TEXTURE_MAPPER_GL to maintain
consistency with Qt.

> configure.ac:397
> +if test "$enable_webgl" = "yes" ||  test "$with_accelerated_compositing" =
"texmap-cairo"	|| test "$with_accelerated_compositing" = "texmap-opengl" ;
then

There's an extra space before the second "test" here.

> configure.ac:1156
> +AM_CONDITIONAL([USE_ACCELERATED_COMPOSITING], [test
"$with_accelerated_compositing" = "texmap-cairo"])
> +AM_CONDITIONAL([USE_ACCELERATED_COMPOSITING], [test
"$with_accelerated_compositing" = "texmap-opengl"])
> +AM_CONDITIONAL([USE_ACCELERATED_COMPOSITING_TEXTURE_MAPPER_CAIRO], [test
"$with_accelerated_compositing" = "texmap-cairo"])
> +AM_CONDITIONAL([USE_ACCELERATED_COMPOSITING_TEXTURE_MAPPER_OPENGL], [test
"$with_accelerated_compositing" = "texmap-opengl"])

Maybe just cairo, opengl and clutter.