[webkit-reviews] review granted: [Bug 72815] [CMake] Share build system options across ports : [Attachment 115965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 09:39:00 PST 2011

Daniel Bates <dbates at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 72815: [CMake] Share build system options across ports

Attachment 115965: Patch

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115965&action=review

Yay for less duplication!

> Source/cmake/WebKitFeatures.cmake:3
> +MACRO (WEBKIT_OPTION_DEFINE _name _description _initialvalue)

Nit: I've noticed an inconsistency in the placement of a space between the
directive name and the opening parenthesis '('. You seem to always place a
space between the MACRO directive and its opening parenthesis, but you don't
carry over this style to other directives such as MESSAGE, SET, and STRING
throughout this patch. I suggest picking a style and being consistent.

More information about the webkit-reviews mailing list