[webkit-reviews] review denied: [Bug 73556] Web Inspector: use object properties, not element attributes to pass preferred panel/line/request id in linkified anchors : [Attachment 117412] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 1 09:04:34 PST 2011
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 73556: Web Inspector: use object properties, not element attributes to pass
preferred panel/line/request id in linkified anchors
https://bugs.webkit.org/show_bug.cgi?id=73556
Attachment 117412: Patch
https://bugs.webkit.org/attachment.cgi?id=117412&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117412&action=review
>> Source/WebCore/inspector/front-end/AuditFormatters.js:98
>
> Where is + 1?
I mean if extensions is the only subsystem using 1-based line numbers, we
should limit its use to extensions.
More information about the webkit-reviews
mailing list