[webkit-reviews] review canceled: [Bug 73560] [Qt] [WK2] Support customizing popup menus with QML : [Attachment 117415] Patch

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has canceled Caio Marcelo
de Oliveira Filho <cmarcelo at webkit.org>'s request for review:
Bug 73560: [Qt] [WK2] Support customizing popup menus with QML
https://bugs.webkit.org/show_bug.cgi?id=73560

Attachment 117415: Patch
https://bugs.webkit.org/attachment.cgi?id=117415&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117415&action=review


Thanks for the comments, Kenne.

>> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:465
>> +QDeclarativeComponent* QQuickWebViewExperimental::popupMenu() const
> 
> I dont like the name popup... It is not really a popup, that highly depends
on the implementation. What about selectorMenu ? or similar. It comes from the
select tag, which has options.
> 
> Maybe optionMenu or just OptionSelector? like FileSelector.

Maybe ItemSelector is better then? (like Grob branch)

>> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:53
>> +	    IsSeparatorRole = Qt::UserRole + 2
> 
> How do we handle indentation? (grouped options)? Also what about multi
selection? pre selections ? Did you check the grob webkit patches?

I mentioned grouped options in a FIXME, maybe it's better to just go forward
and implement in this patch (since it would only involve Qt code). :-)

I think we could first move to the QML supporting what we have now, then start
upstreaming multiple selection support (that Grob branch have) in a separate
patch.

>> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:117
>> +	case IsSeparatorRole:
> 
> Why not just SeparatorRole?

In QML usage, I though model.isSeparator was better than model.separator.