[webkit-reviews] review granted: [Bug 73441] [Qt][WK2] ASSERT at QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising zero sized views. : [Attachment 117184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 02:28:46 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zalan Bujtas
<zbujtas at gmail.com>'s request for review:
Bug 73441: [Qt][WK2] ASSERT at
QQuickWebViewPrivate::computeViewportConstraints() when API test is exercising
zero sized views.
https://bugs.webkit.org/show_bug.cgi?id=73441

Attachment 117184: Patch
https://bugs.webkit.org/attachment.cgi?id=117184&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117184&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:211
> +    // Return default values for zero sized viewport.

Maybe add a comment that this will be ignored, ie. not applied


More information about the webkit-reviews mailing list