[webkit-reviews] review denied: [Bug 72939] Asynchronous SpellChecker should consider multiple requests : [Attachment 117377] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 1 01:52:17 PST 2011
MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 72939: Asynchronous SpellChecker should consider multiple requests
https://bugs.webkit.org/show_bug.cgi?id=72939
Attachment 117377: Patch
https://bugs.webkit.org/attachment.cgi?id=117377&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117377&action=review
> Source/WebCore/editing/SpellChecker.cpp:134
> {
It looks we now can merge doRequestCheckingFor and requestCheckingFor().
> Source/WebCore/editing/SpellChecker.cpp:162
> + if (request->rootEditableElement() != (*it)->rootEditableElement())
Could you store |request->rootEditableElement()| to a local var to save extra
computation?
> Source/WebCore/editing/SpellChecker.cpp:165
> + fprintf(stderr, "REMOVED!\n");
Please remove this.
More information about the webkit-reviews
mailing list