[webkit-reviews] review denied: [Bug 73099] Web Inspector: Unsafe cross origin access errors should show stack trace in console. : [Attachment 117173] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 01:37:28 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 73099: Web Inspector: Unsafe cross origin access errors should show stack
trace in console.
https://bugs.webkit.org/show_bug.cgi?id=73099

Attachment 117173: Patch
https://bugs.webkit.org/attachment.cgi?id=117173&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117173&action=review


Passing the line number along with the stack is a bit confusing. I'd suggest
that you introduce Console::addErrorMessage() receiving the stack trace only
(no explicit location). You could assign one to XMLHttpRequest from within
bindings instead of setting the line number. Sounds like all other call sites
are falling back to the default values in either case.

> Source/WebCore/page/DOMWindow.cpp:928
> +	       console()->addMessage(JSMessageSource, LogMessageType,
ErrorMessageLevel, message, 0, String(), timer->stackTrace());

Should it be "0"?

> Source/WebCore/page/DOMWindow.cpp:1778
> +    console()->addMessage(JSMessageSource, LogMessageType,
ErrorMessageLevel, message, 1, String(), stackTrace.release());

Or "1" ?

> Source/WebCore/xml/XMLHttpRequest.cpp:163
> +    , m_lastSendLineNumber(1)

I.e. why did this change?


More information about the webkit-reviews mailing list