[webkit-reviews] review denied: [Bug 73404] [WebSocket] bufferedAmount calculation is wrong in CLOSING and CLOSED state : [Attachment 117331] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 1 00:19:49 PST 2011


Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 73404: [WebSocket] bufferedAmount calculation is wrong in CLOSING and
CLOSED state
https://bugs.webkit.org/show_bug.cgi?id=73404

Attachment 117331: Patch
https://bugs.webkit.org/attachment.cgi?id=117331&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117331&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests because this change contains no functional update.

Correcting bufferedAmount calculation must be a functional change.

> Source/WebCore/ChangeLog:10
> +	   * websockets/WebSocket.cpp: Change bufferedAmount calculation logic.


Please explain what is changed concretely.

> Source/WebCore/websockets/WebSocket.cpp:132
> +    if (std::numeric_limits<unsigned long>::max() - a < b)
> +	   return std::numeric_limits<unsigned long>::max();

We usually declare "using namespace std;" and don't prepend "std::".


More information about the webkit-reviews mailing list