[webkit-reviews] review denied: [Bug 67363] WebSocket: Fix bufferedAmount after WebSocket is closed : [Attachment 105901] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 67363: WebSocket: Fix bufferedAmount after WebSocket is closed
https://bugs.webkit.org/show_bug.cgi?id=67363

Attachment 105901: Patch
https://bugs.webkit.org/attachment.cgi?id=105901&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105901&action=review


>
LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:25
> +function getExpectedFramingOverhead(payloadSize)
> +{
> +    var overhead = 2 + 4; // Base header size and masking key size.
> +    if (payloadSize > 0xFFFF)
> +	   overhead += 8;
> +    else if (payloadSize > 125)
> +	   overhead += 2;
> +    return overhead;
> +}

Copying the code logic in C++ to the test code makes the test meaningless.  We
should have constant values of the overheads for each test cases.

>
LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:59
> +function doTest(message)

nit: doTest -> testBufferedAmount ?