[webkit-reviews] review denied: [Bug 67271] Rename colorSelected to didChooseColor : [Attachment 105898] patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 67271: Rename colorSelected to didChooseColor
https://bugs.webkit.org/show_bug.cgi?id=67271

Attachment 105898: patch
https://bugs.webkit.org/attachment.cgi?id=105898&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105898&action=review


r- because ChangeLog is not reasonable.

> Source/WebCore/ChangeLog:11
> +	   (WebCore::ColorInputType::didChooseColor): Renamed colorSelected to
didChooseColor. Chromium WebKit API
> +	   will be using didChooseColor and so this will match that.

In this case, the name in Chromium API won't be a reason to change WebCore.
Anyway, didSomething() is common in WebCore.  So I think this change is
reasonable.