[webkit-reviews] review granted: [Bug 67362] Define PTHREAD_KEYS_MAX to fix Android port build : [Attachment 105897] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 23:21:28 PDT 2011


Adam Barth <abarth at webkit.org> has granted  review:
Bug 67362: Define PTHREAD_KEYS_MAX to fix Android port build
https://bugs.webkit.org/show_bug.cgi?id=67362

Attachment 105897: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=105897&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105897&action=review


> Source/JavaScriptCore/ChangeLog:8
> +	   Define PTHREAD_KEYS_MAX to fix Android port build.
> +	   https://bugs.webkit.org/show_bug.cgi?id=67362
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * wtf/ThreadIdentifierDataPthreads.cpp:

It would be good to include the information from the bug about this being a
missing feature of bionic in the ChangeLog.


More information about the webkit-reviews mailing list