[webkit-reviews] review denied: [Bug 67270] Rename closeColorChooser to cleanupColorChooser : [Attachment 105884] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 31 19:30:20 PDT 2011
Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 67270: Rename closeColorChooser to cleanupColorChooser
https://bugs.webkit.org/show_bug.cgi?id=67270
Attachment 105884: patch
https://bugs.webkit.org/attachment.cgi?id=105884&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105884&action=review
> Source/WebCore/ChangeLog:12
> + I need to take care of any color chooser listeners, I am renaming
this to cleanup. This will close the color
Using the word 'I' in ChangeLog looks strange.
> Source/WebCore/ChangeLog:25
> + * page/ChromeClient.h:
> +
> +2011-08-31 Keishi Hattori <keishi at webkit.org>
> +
> + Remove closeColorChooser call from
FrameLoader::transitionToCommitted
> + https://bugs.webkit.org/show_bug.cgi?id=67267
There are two ChangeLog entries.
More information about the webkit-reviews
mailing list