[webkit-reviews] review granted: [Bug 67174] Unzip initialization lists and constructors in JSCell hierarchy (4/7) : [Attachment 105803] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67174: Unzip initialization lists and constructors in JSCell hierarchy
(4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Attachment 105803: Patch
https://bugs.webkit.org/attachment.cgi?id=105803&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105803&action=review


> Source/JavaScriptCore/runtime/JSArray.h:77
> +	   static JSArray* create(JSGlobalData&, Structure*, unsigned
initialLength, ArrayCreationMode createMode);

The argument name here, createMode, is not helpful and should be omitted.

> Source/JavaScriptCore/runtime/JSFunction.h:55
> +	   static JSFunction* create(ExecState*, JSGlobalObject*, Structure*,
int length, const Identifier& name, NativeFunction);

Is making these functions non-inline a good choice speed-wise?

> Source/JavaScriptCore/runtime/JSStaticScopeObject.h:53
> +	   void finishCreation(ExecState* exec, const Identifier& ident,
JSValue value, unsigned attributes)

Normally we try not to abbreviate. So the name here would be identifier rather
than ident.