[webkit-reviews] review granted: [Bug 67321] [CSS3 Backgrounds and Borders] Implement border-image-slice : [Attachment 105833] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 67321: [CSS3 Backgrounds and Borders] Implement border-image-slice
https://bugs.webkit.org/show_bug.cgi?id=67321

Attachment 105833: Patch
https://bugs.webkit.org/attachment.cgi?id=105833&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105833&action=review


r=me! Dave mentioned on irc that he fixed all of the style issues except the
RefPtr thing, which there is an open question about. Either way,
parseBorderImage (which already exists in the codebase) does the same thing, so
it's probably okay to check some more similar code in while Dave's figuring out
the right thing.

> Source/WebCore/css/CSSParser.cpp:5318
> +    PassRefPtr<CSSBorderImageSliceValue> commitBorderImageSlice()

I feel like some comments would be nice in this function. I think I can make
out why m_top is asserted and why m_bottom and m_left are set if there is no
m_right by looking at the patch as a whole, but some comments would be nice so
that it's less mysterious out of context.