[webkit-reviews] review granted: [Bug 67234] REGRESSION(r93902): Can't open external links on gmail : [Attachment 105828] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 67234: REGRESSION(r93902): Can't open external links on gmail
https://bugs.webkit.org/show_bug.cgi?id=67234

Attachment 105828: Patch
https://bugs.webkit.org/attachment.cgi?id=105828&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105828&action=review


This bug couldn't happen on Windows, could it?

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:521
> +    // FIXME: Move this to ArgumentCodersCFMac.mm and change this file back
to be C++

Is there a reason why this cannot be done right away? Leaving
ArgumentCodersCF.cpp in Objective C++ mode seems unfortunate.

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:525
> +	   result = reinterpret_cast<CFURLRef>([NSURL URLWithString:@""]);

Would be nice to avoid leaving an autoreleased object behind - NSURL has
initWithString:.