[webkit-reviews] review granted: [Bug 67299] Add Android's platform specification and atomic functions : [Attachment 105805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 13:54:07 PDT 2011


Adam Barth <abarth at webkit.org> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 67299: Add Android's platform specification and atomic functions
https://bugs.webkit.org/show_bug.cgi?id=67299

Attachment 105805: Patch
https://bugs.webkit.org/attachment.cgi?id=105805&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105805&action=review


The Platform.h changes look fine to me.

> Source/JavaScriptCore/wtf/Platform.h:698
>  #if !OS(WINDOWS) && !OS(SOLARIS) && !OS(QNX) \
>      && !OS(SYMBIAN) && !OS(HAIKU) && !OS(RVCT) \
> -    && !PLATFORM(BREWMP)
> +    && !OS(ANDROID) && !PLATFORM(BREWMP)

This should probably be a whitelist, but that's a change for another day.


More information about the webkit-reviews mailing list