[webkit-reviews] review granted: [Bug 67172] Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac : [Attachment 105773] Build Fix for GTK + Style fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 11:15:53 PDT 2011


Chris Marrin <cmarrin at apple.com> has granted Dominik Röttsches
<dominik.rottsches at linux.intel.com>'s request for review:
Bug 67172: Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add
a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Attachment 105773: Build Fix for GTK + Style fix
https://bugs.webkit.org/attachment.cgi?id=105773&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
This patch isn't ideal. Generally, you get a delete, a new file (like you have
here) and then a diff on that new file showing all the renamed functions. The
way you've done it, you can't see the actual changes to the new file. But I'll
trust that this is what you've done. So r=me. 

I'm confused about why the ews bots didn't catch this mistake.


More information about the webkit-reviews mailing list