[webkit-reviews] review granted: [Bug 66756] Implement an Event constructor in V8 : [Attachment 105787] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara <haraken at google.com>'s
request for review:
Bug 66756: Implement an Event constructor in V8
https://bugs.webkit.org/show_bug.cgi?id=66756

Attachment 105787: Patch
https://bugs.webkit.org/attachment.cgi?id=105787&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105787&action=review


This looks great.

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:59
> +    if (AllowAllocation::current())
> +	   return args.Holder();

Crazy.	Is this a v8 function?	Why does it not require the v8 namespace?  Are
we using namespace v8 somewhere?  (We shouldn't be.)

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:75
> +    return toV8(event.release(), args.Holder());

The holder is always the global object.  I guess that makes sense.