[webkit-reviews] review granted: [Bug 67278] Web Inspector: Having the "Metrics" pane open affects the node highlight display : [Attachment 105769] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 05:21:21 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 67278: Web Inspector: Having the "Metrics" pane open affects the node
highlight display
https://bugs.webkit.org/show_bug.cgi?id=67278

Attachment 105769: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=105769&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105769&action=review


> Source/WebCore/inspector/front-end/MetricsSidebarPane.js:265
> +	       boxElement.addEventListener("mouseover",
this._highlightDOMNode.bind(this, true, name === "position" ? "" : name),
false);

Could you pass "all" instead of "" for clarity?


More information about the webkit-reviews mailing list