[webkit-reviews] review granted: [Bug 66536] Implement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm : [Attachment 105706] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara <haraken at google.com>'s
request for review:
Bug 66536: Implement Web IDL Constructor extended attribute in IDLParser.pm and
CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=66536

Attachment 105706: Patch
https://bugs.webkit.org/attachment.cgi?id=105706&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105706&action=review


This looks great.  We'll need to do something similar to CodeGeneratorJS if we
want to use this in more than a handful of IDL files.

Thanks for writing this patch.

> Source/WebCore/bindings/scripts/IDLParser.pm:158
> +	   if ($str =~ /^\s*=/) {
> +	       # Parse '=' value | '=' value ','
> +	       $str =~ s/^\s*=//;
> +	       if ($str =~ /^\s*([^,]*),?/) {

Perl makes me sad face.