[webkit-reviews] review granted: [Bug 53055] REGRESSION: Rendering artifacts on a rotated, pattern filled shape : [Attachment 105719] patch, fixing Darin's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 53055: REGRESSION: Rendering artifacts on a rotated, pattern filled shape
https://bugs.webkit.org/show_bug.cgi?id=53055

Attachment 105719: patch, fixing Darin's comments
https://bugs.webkit.org/attachment.cgi?id=105719&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105719&action=review


> Source/WebCore/platform/graphics/cg/PatternCG.cpp:68
> +    // If we're repeating in both directions, we can use image-backed
patterns
> +    // instead of custom patterns, and fix tiling-edge pixel cracks

In WebKit coding style we use a period at the end of a sentence like this one.
I would say “avoid” rather than “fix”.

> Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:120
> +	   // Ignore 2D rotation, as it doesn't affect the size of the tile

Again, periods at the ends of comments, even ones that aren’t full sentences.

> Source/WebCore/rendering/svg/SVGImageBufferTools.cpp:128
> +    // FIXME67242: Don't round-trip through TransformationMatrix.

This is not our usual format. Ramming the bug number up against FIXME is not
how we do it.

I’m not sure this really needs a FIXME. Sure, it would be more elegant, but
what’s the big deal? Probably overkill to include the comment. Unless you said
in the comment *why* it needs to be fixed.