[webkit-reviews] review granted: [Bug 67230] [mac] Add text search API for getting the DOM range of a text match : [Attachment 105718] Add -[WebView DOMRangeOfString:relativeTo:options:]

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 67230: [mac] Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Attachment 105718: Add -[WebView DOMRangeOfString:relativeTo:options:]
https://bugs.webkit.org/attachment.cgi?id=105718&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105718&action=review


> Source/WebCore/dom/Range.h:107
> -    void setStart(const Position&, ExceptionCode&);
> -    void setEnd(const Position&, ExceptionCode&);
> +    void setStart(const Position&, ExceptionCode& = ASSERT_NO_EXCEPTION);
> +    void setEnd(const Position&, ExceptionCode& = ASSERT_NO_EXCEPTION);

I think that these should not even take ExceptionCode& since they are internal
functions, not DOM API. ExceptionCode& is ugly for internal use, except where
it's intended to be used for helper functions that in turn are used implement
DOM API functions. ASSERT_NO_EXCEPTION is OK for now, but later we should just
get rid of that.