[webkit-reviews] review canceled: [Bug 67150] Would like API to use a custom device scale factor for a particular WebView/WKView : [Attachment 105695] Patch with style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 30 15:44:04 PDT 2011


Beth Dakin <bdakin at apple.com> has canceled Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 67150: Would like API to use a custom device scale factor for a particular
WebView/WKView
https://bugs.webkit.org/show_bug.cgi?id=67150

Attachment 105695: Patch with style fixes
https://bugs.webkit.org/attachment.cgi?id=105695&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here's a patch that I believe addresses all comments so far, except for Darin's
comment about strange input values. It's true that callers of this API that
send in crazy float values are not protected. It's also true that to un-set the
override, a caller would have to set the overrideBackingScaleFactor to 0, which
is a little strange. I am open to suggestions here for restricting the values
or adding additional API to turn the override off (instead of relying on 0).


More information about the webkit-reviews mailing list