[webkit-reviews] review granted: [Bug 67175] Get rid of toInputElement() : [Attachment 105698] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 30 14:45:10 PDT 2011


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 67175: Get rid of toInputElement()
https://bugs.webkit.org/show_bug.cgi?id=67175

Attachment 105698: Patch
https://bugs.webkit.org/attachment.cgi?id=105698&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105698&action=review


> Source/WebCore/html/shadow/TextControlInnerElements.cpp:137
> +    if (toHTMLInputElement(host)->maxResults() < 0)
> +	   return decorationId;
> +    if (toHTMLInputElement(host)->maxResults() > 0)
> +	   return resultsId;

Seems a little weak to call maxResults twice here. But maybe it’s just an
inlined accessor and so no additional performance cost.


More information about the webkit-reviews mailing list