[webkit-reviews] review granted: [Bug 4860] div align="center" rendering problem : [Attachment 105441] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 4860: div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Attachment 105441: Patch
https://bugs.webkit.org/attachment.cgi?id=105441&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Note that startOffsetForLine is doing the wrong thing for RTL and returning an
offset from the left when it should be from the right. I broke this a while
back. startAlignedOffsetForLine has the same mistake. I'm cool with landing as
is, but your next patch will hopefully fix both of these methods to do the
right thing for RTL (before you tackle the parent vs. containing block issue
with RTL).