[webkit-reviews] review denied: [Bug 67208] Get rid of platform specific undefs for NO_ERROR and VERSION in GraphicsContext3D : [Attachment 105649] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 67208: Get rid of platform specific undefs for NO_ERROR and VERSION in
GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=67208

Attachment 105649: Patch
https://bugs.webkit.org/attachment.cgi?id=105649&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105649&action=review


This fails to compile. See the Qt EWS build failure. It’s because the IDL and
C++ names need to match. To change the names we’d probably need a new feature
in the bindings generation script.

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:145
> -	   const unsigned int NO_ERROR			     = 0;
> +	   const unsigned int NO_ERROR			     = 0; // This is
named GC3D_NO_ERROR in GraphicsContext3D to avoid clash with system defines on
some platforms

I’m not sure this comment is helpful here. Don’t we have something in the
IDL-generation process that requires that the C++ constant and the IDL constant
have the same name and same value? I had thought we did, and I’m surprised you
are not having problems compiling.

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:288
> -	   const unsigned int VERSION			     = 0x1F02;
> +	   const unsigned int VERSION			     = 0x1F02;	// This
is named GC3D_VERSION in GraphicsContext3D to avoid clash with system defines
on some platforms

Ditto.