[webkit-reviews] review denied: [Bug 67103] Implement list style properties in CSSStyleApplyProperty. : [Attachment 105573] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 67103: Implement list style properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67103

Attachment 105573: Patch
https://bugs.webkit.org/attachment.cgi?id=105573&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105573&action=review


> Source/WebCore/rendering/style/RenderStyle.h:607
> -    StyleImage* listStyleImage() const { return
inherited->list_style_image.get(); }
> +    PassRefPtr<StyleImage> listStyleImage() const { return
inherited->list_style_image; }

This change is not a good idea. While it’s convenient to have a PassRefPtr in
CSSStyleApplyProperty.cpp, in other call sites using this type will result in
reference count churn.