[webkit-reviews] review granted: [Bug 67179] [chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts : [Attachment 105579] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Nat Duca <nduca at chromium.org>'s
request for review:
Bug 67179: [chromium] Allow GraphicsContexts to be created from
MockWebGraphicsContexts
https://bugs.webkit.org/show_bug.cgi?id=67179

Attachment 105579: Patch
https://bugs.webkit.org/attachment.cgi?id=105579&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=105579&action=review


Looks good overall. This one will have to be merged with the fix for
https://bugs.webkit.org/show_bug.cgi?id=67172 which just landed. Couple of
minor comments. I'll r+ this in case you want to fix the issues upon landing,
or feel free to upload another version.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:120
> +PassRefPtr<GraphicsContext3D>
GraphicsContext3DInternal::createFromWebContext(PassOwnPtr<WebKit::WebGraphicsC
ontext3D> webContext, GraphicsContext3D::Attributes attrs, HostWindow*
hostWindow, GraphicsContext3D::RenderStyle renderStyle)

This is clearly the key method. I see that there's really no other place to put
it (can't go in GC3D, because that can't reference our WebKit API). However
could you perhaps name it something like createGraphicsContext3DFromWebContext
to avoid confusion?

> Source/WebKit/chromium/src/GraphicsContext3DInternal.h:59
> +    static PassRefPtr<GraphicsContext3D>
createFromWebContext(PassOwnPtr<WebKit::WebGraphicsContext3D>,
GraphicsContext3D::Attributes, HostWindow*, GraphicsContext3D::RenderStyle);

Could you indicate that the createFromWebContext method (or whatever it ends up
being called) is only for testing purposes?